Skip to content

Remove SQL until it bumps log4j 2.17.1.#1419

Merged
dblock merged 1 commit intoopensearch-project:mainfrom
dblock:remove-sql-log4j-2.17.1
Dec 30, 2021
Merged

Remove SQL until it bumps log4j 2.17.1.#1419
dblock merged 1 commit intoopensearch-project:mainfrom
dblock:remove-sql-log4j-2.17.1

Conversation

@dblock
Copy link
Copy Markdown
Member

@dblock dblock commented Dec 30, 2021

Signed-off-by: dblock dblock@amazon.com

Description

opensearch-project/sql#354 is failing because there's no snapshot build, and there's no snapshot build because sql is included in it; remove it for now

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: dblock <dblock@amazon.com>
@dblock dblock requested a review from a team as a code owner December 30, 2021 14:51
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 30, 2021

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.13%. Comparing base (80b3fb4) to head (baf1148).
⚠️ Report is 2844 commits behind head on main.

❌ Your project status has failed because the head coverage (94.13%) is below the target coverage (98.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1419   +/-   ##
=========================================
  Coverage     94.13%   94.13%           
  Complexity       11       11           
=========================================
  Files           139      139           
  Lines          3086     3086           
  Branches          8        8           
=========================================
  Hits           2905     2905           
  Misses          173      173           
  Partials          8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dblock dblock enabled auto-merge (squash) December 30, 2021 16:59
@dblock dblock merged commit a7a7e96 into opensearch-project:main Dec 30, 2021
dblock added a commit that referenced this pull request Dec 31, 2021
dblock added a commit to dblock/opensearch-build that referenced this pull request Dec 31, 2021
)"

This reverts commit a7a7e96.

Signed-off-by: dblock <dblock@dblock.org>
dblock added a commit that referenced this pull request Jan 3, 2022
This reverts commit a7a7e96.

Signed-off-by: dblock <dblock@dblock.org>
@dblock dblock deleted the remove-sql-log4j-2.17.1 branch March 11, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants